Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PA-5749) Add Debian 12 bookworm platform definitions main #2432

Merged
merged 3 commits into from
Dec 12, 2023
Merged

(PA-5749) Add Debian 12 bookworm platform definitions main #2432

merged 3 commits into from
Dec 12, 2023

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Nov 29, 2023

No description provided.

@h0tw1r3 h0tw1r3 requested a review from a team as a code owner November 29, 2023 18:43
amitkarsale
amitkarsale approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@amitkarsale amitkarsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h0tw1r3 h0tw1r3 changed the title (maint) Add Debian 12 bookworm platform definitions (PA-5749) Add Debian 12 bookworm platform definitions main Dec 8, 2023
@h0tw1r3 h0tw1r3 requested a review from amitkarsale December 8, 2023 15:51
@amitkarsale
Copy link
Contributor

amitkarsale commented Dec 11, 2023 •
edited
Loading

@h0tw1r3 can you add jenkins pipeline execution url please. Also you will have to revert puppet-runtime.json and pxp-agent.json files after your build is successful.

@h0tw1r3 h0tw1r3 force-pushed the bookworm branch 2 times, most recently from d1e0586 to b0823ff Compare December 11, 2023 19:26
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Dec 11, 2023

@amitkarsale successful https://jenkins-platform.delivery.puppetlabs.net/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2579/

@amitkarsale amitkarsale merged commit ac1a306 into puppetlabs:main Dec 12, 2023
@h0tw1r3 h0tw1r3 deleted the bookworm branch December 20, 2023 16:57
@joshcooper joshcooper added the maintenance Maintenance chores are typically excluded from changelogs label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkarsale amitkarsale amitkarsale approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h0tw1r3 @amitkarsale @joshcooper